[PATCH v4 1/5] powerpc/lib/sstep: Add cmpb instruction emulation

[Matt Brown]

On Tue, Aug 1, 2017 at 10:44 PM, Segher Boessenkool
<segher at kernel.crashing.org> wrote:
> Hi!
>
> On Mon, Jul 31, 2017 at 10:58:22AM +1000, Matt Brown wrote:
>> @@ -1049,6 +1065,10 @@ int analyse_instr(struct instruction_op *op, struct pt_regs *regs,
>>                       do_cmp_unsigned(regs, val, val2, rd >> 2);
>>                       goto instr_done;
>>
>> +             case 508: /* cmpb */
>> +                     do_cmpb(regs, regs->gpr[rd], regs->gpr[rb], ra);
>> +                     goto instr_done;
>
> Should this then be under an ifdef for 64-bit?

I don't think so, the cmpb instruction should be 32 and 64-bit.
It isn't listed under the '64-bit Fixed-point Logical Instructions'
section in the ISA either.

Thanks,
Matt
>
>
> Segher