[PATCH] hwmon: (ibmpowernv) Add min/max attributes and current sensors

[Cédric Le Goater]

On 04/22/2017 08:11 AM, Michael Ellerman wrote:
> Shilpasri G Bhat <shilpa.bhat at linux.vnet.ibm.com> writes:
>> On 04/21/2017 05:17 PM, Cédric Le Goater wrote:
>>> On 04/21/2017 06:31 AM, Shilpasri G Bhat wrote:
>>>> diff --git a/drivers/hwmon/ibmpowernv.c b/drivers/hwmon/ibmpowernv.c
>>>> index 6d2e660..1f329fa8 100644
>>>> --- a/drivers/hwmon/ibmpowernv.c
>>>> +++ b/drivers/hwmon/ibmpowernv.c
>>>> @@ -65,7 +66,8 @@ enum sensors {
>>>>  	{"fan", "ibm,opal-sensor-cooling-fan"},
>>>>  	{"temp", "ibm,opal-sensor-amb-temp"},
>>>>  	{"in", "ibm,opal-sensor-power-supply"},
>>>> -	{"power", "ibm,opal-sensor-power"}
>>>> +	{"power", "ibm,opal-sensor-power"},
>>>> +	{"curr"}, /* Follows newer device tree compatible ibm,opal-sensor */
>>>
>>> why isn't there a compatible string ? 
>>
>> Skiboot exports "ibm,opal-sensor" as compatible string for all the inband
>> sensors. Now if I define that as the compatible string here, then all the
>> sensors would get identified as "curr" type of sensor by the driver.
> 
> So fix it in skiboot?


After a memory refresh, this table is to maintain compatibility with 
the support of the FSP sensors in old firmware. These have peculiar
device node names and properties.  

So What the code is doing looks correct. But, you should also modify 
the 'enum sensors' to include a CURRENT value.

Thanks,

C.