powerpc: Drop include of linux/io.h from asm/io.h
Michael Ellerman
patch-notifications at ellerman.id.au
Wed Apr 19 13:47:17 AEST 2017
On Thu, 2017-04-13 at 13:14:36 UTC, Michael Ellerman wrote:
> Currently powerpc's asm/io.h includes linux/io.h, and linux/io.h
> includes asm/io.h.
>
> This can cause problems because depending on which is included first the
> order of definitions between the two files will change.
>
> The include of linux/io.h was added back in 2008 in commit b41e5fffe8b8
> ("[POWERPC] devres: Add devm_ioremap_prot()"). It's not entirely clear
> it was needed then, but devm_ioremap_prot() has since been removed
> entirely as unused, in dedd24a12fe6 ("powerpc: Remove unused
> devm_ioremap_prot()").
>
> So it seems to be unnecessary and can potentially cause problems, so
> remove the include of linux/io.h from asm/io.h
>
> Signed-off-by: Michael Ellerman <mpe at ellerman.id.au>
Applied to powerpc next.
https://git.kernel.org/powerpc/c/590c369e7ecc00be736be39ae0c62d
cheers
More information about the Linuxppc-dev
mailing list