[PATCH 10/17] cxlflash: Fence EEH during probe

Matthew R. Ochs mrochs at linux.vnet.ibm.com
Fri Apr 14 07:46:06 AEST 2017


> On Apr 13, 2017, at 1:27 AM, Andrew Donnellan <andrew.donnellan at au1.ibm.com> wrote:
> 
> On 13/04/17 05:14, Uma Krishnan wrote:
>> From: "Matthew R. Ochs" <mrochs at linux.vnet.ibm.com>
>> 
>> An EEH during probe can lead to a crash as the recovery thread races
>> with the probe thread. To avoid this issue, introduce new states to
>> fence out EEH recovery until probe has completed. Also ensure the reset
>> wait queue is flushed during device removal to avoid orphaned threads.
>> 
>> Signed-off-by: Matthew R. Ochs <mrochs at linux.vnet.ibm.com>
>> Signed-off-by: Uma Krishnan <ukrishn at linux.vnet.ibm.com>
> 
> The use of the term "fence" in the commit message might be a bit confusing given how the term is already used in the context of EEH :)

Hi Andrew,

I agree that it could be a bit misleading but think the commit message is
descriptive enough to avoid confusion. If you feel strongly about it I'm happy
to reword the commit.


-matt


More information about the Linuxppc-dev mailing list