[7/7] crypto: caam/qi - add ablkcipher and authenc algorithms

[Laurentiu Tudor]

-----Original Message-----
From: Michael Ellerman [mailto:mpe at ellerman.id.au] 
Sent: Friday, April 07, 2017 4:22 PM
To: Laurentiu Tudor <laurentiu.tudor at nxp.com>; Horia Geantă <horia.geanta at nxp.com>; Herbert Xu <herbert at gondor.apana.org.au>; Scott Wood <oss at buserror.net>; Roy Pledge <roy.pledge at nxp.com>
Cc: Claudiu Manoil <claudiu.manoil at nxp.com>; Cristian Stoica <cristian.stoica at nxp.com>; Dan Douglass <dan.douglass at nxp.com>; linux-arm-kernel at lists.infradead.org; Vakul Garg <vakul.garg at nxp.com>; linuxppc-dev at lists.ozlabs.org; David S. Miller <davem at davemloft.net>; Alexandru Porosanu <alexandru.porosanu at nxp.com>; linux-crypto at vger.kernel.org
Subject: Re: [7/7] crypto: caam/qi - add ablkcipher and authenc algorithms
Importance: High

Laurentiu Tudor <laurentiu.tudor at nxp.com> writes:

> On 04/05/2017 01:06 PM, Michael Ellerman wrote:
>> Laurentiu Tudor <laurentiu.tudor at nxp.com> writes:
>>
>>> Hi Michael,
>>>
>>> Just a couple of basic things to check:
>>>    - was the dtb updated to the newest?
>>
>> Possibly not, it's an automated build/boot, I'll have to check what 
>> it does with the dtb.
>>
>>>    - is the qman node present? This should be easily visible in 
>>> /proc/device-tree/soc at ffe000000/qman at 318000.
>>
>> No it's not there.
>>
>> That's running linux-next with:
>>
>> CONFIG_CRYPTO_DEV_FSL_CAAM_CRYPTO_API_QI=n
>>
>>
>> Does that mean I didn't update the device tree?
>
> I think so. Also, I just checked that the node is actually there by 
> compiling p5020ds.dts and then decompiling the dtb.

> OK, I'll make sure I update the DTB.
> 
> It will still be good if the code was a bit more robust about the qman being missing.

Totally agree. We should handle this error condition.

---
Thanks & Best Regards, Laurentiu