[PATCH] powerpc/fadump: Fix build break when CONFIG_PROC_VMCORE=n

[Balbir Singh]

On 30/09/16 10:51, Michael Ellerman wrote:
> The fadump code calls vmcore_cleanup() which only exists if
> CONFIG_PROC_VMCORE=y. We don't want to depend on CONFIG_PROC_VMCORE,
> because it's user selectable, so just wrap the call in an #ifdef.
> 
> Signed-off-by: Michael Ellerman <mpe at ellerman.id.au>
> ---
>  arch/powerpc/kernel/fadump.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/powerpc/kernel/fadump.c b/arch/powerpc/kernel/fadump.c
> index b3a663333d36..8d461303dd13 100644
> --- a/arch/powerpc/kernel/fadump.c
> +++ b/arch/powerpc/kernel/fadump.c
> @@ -1104,7 +1104,9 @@ static ssize_t fadump_release_memory_store(struct kobject *kobj,
>  		 * Take away the '/proc/vmcore'. We are releasing the dump
>  		 * memory, hence it will not be valid anymore.
>  		 */
> +#ifdef CONFIG_PROC_VMCORE
>  		vmcore_cleanup();
> +#endif

I wonder if this should be fixed in crash_dump.h more generically.

Balbir Singh.