[PATCH 03/13] powerpc: move set_soft_enabled() and rename

Madhavan Srinivasan maddy at linux.vnet.ibm.com
Mon Sep 19 14:05:46 AEST 2016



On Friday 16 September 2016 03:20 PM, Nicholas Piggin wrote:
> On Thu, 15 Sep 2016 18:31:53 +0530
> Madhavan Srinivasan <maddy at linux.vnet.ibm.com> wrote:
>
>> Move set_soft_enabled() from powerpc/kernel/irq.c to
>> asm/hw_irq.c. and rename it soft_enabled_set().
>> THis way paca->soft_enabled updates can be forced.
> Could you just tidy up the changelog a little?
>
> You are renaming it I assume because you are going to introduce more
> soft_enabled_x() functions, and that the namespace works better as a
> prefix than a postfix.
>
> You are moving it so all paca->soft_enabled updates can be done via
> these access functions rather than open coded.
>
> Did I get that right?

Yes. That is right. My bad. Will fix the commit message and changelog.

>
> Reviewed-by: Nicholas Piggin <npiggin at gmail.com>
>



More information about the Linuxppc-dev mailing list