powerpc/kernel: Fix size of NUM_CPU_FTR_KEYS on 32-bit

Michael Ellerman patch-notifications at ellerman.id.au
Tue Sep 13 08:08:59 AEST 2016


On Mon, 2016-12-09 at 02:54:50 UTC, Michael Ellerman wrote:
> The number of CPU feature keys is meant to map 1:1 to the number of CPU
> feature flags defined in cputable.h, and the latter must fit in an
> unsigned long.
> 
> In commit 4db7327194db ("powerpc: Add option to use jump label for
> cpu_has_feature()"), I incorrectly defined NUM_CPU_FTR_KEYS to 64.
> 
> There should be no real adverse consequences of this bug, other than us
> allocating too many keys.
> 
> Fix it by using BITS_PER_LONG.
> 
> Fixes: 4db7327194db ("powerpc: Add option to use jump label for cpu_has_feature()")
> Tested-by: Meelis Roos <mroos at linux.ee>
> Signed-off-by: Michael Ellerman <mpe at ellerman.id.au>

Applied to powerpc fixes.

https://git.kernel.org/powerpc/c/ffed15d3ce3f710b94e6f402e1

cheers


More information about the Linuxppc-dev mailing list