[PATCH] powerpc: Remove all usages of NO_IRQ

Arnd Bergmann arnd at arndb.de
Thu Sep 8 19:28:22 AEST 2016


On Thursday, September 8, 2016 7:16:12 PM CEST Michael Ellerman wrote:
> 
> The rest below I haven't looked at yet, I'm not entirely clear on which
> FSL pieces are able to build on arm.
> 
> > drivers/dma/bestcomm/bestcomm.c:              if (tsk->irq != NO_IRQ)
> > drivers/dma/fsl_raid.c:       if (chan->irq == NO_IRQ) {
> > drivers/dma/fsldma.c: if (fdev->irq != NO_IRQ) {
> > drivers/dma/mpc512x_dma.c:    if (mdma->irq == NO_IRQ) {
> > drivers/edac/mpc85xx_edac.c:  pdata->irq = NO_IRQ;
> > drivers/iommu/fsl_pamu.c:     if (irq != NO_IRQ)
> > drivers/media/platform/fsl-viu.c:     if (viu_irq == NO_IRQ) {
> > drivers/mtd/nand/mpc5121_nfc.c:       if (prv->irq == NO_IRQ) {
> > drivers/net/ethernet/freescale/fs_enet/mac-fcc.c:     if (fep->interrupt == NO_IRQ)
> > drivers/net/ethernet/freescale/fs_enet/mac-fec.c:     if (fep->interrupt == NO_IRQ)
> > drivers/net/ethernet/freescale/fs_enet/mac-scc.c:     if (fep->interrupt == NO_IRQ)
> > drivers/soc/fsl/qe/qe_ic.c:           return NO_IRQ;
> > drivers/spi/spi-mpc52xx.c:    if (status && (irq != NO_IRQ))
> > drivers/tty/ehv_bytechan.c:   if (stdout_irq == NO_IRQ) {
> > drivers/tty/serial/cpm_uart/cpm_uart_core.c:  if (pinfo->port.irq == NO_IRQ) {
> > drivers/uio/uio_fsl_elbc_gpcm.c:      if (irq != NO_IRQ) {
> > drivers/usb/host/ehci-grlib.c:        if (irq == NO_IRQ) {
> > drivers/usb/host/ehci-ppc-of.c:       if (irq == NO_IRQ) {
> > drivers/usb/host/fhci-hcd.c:  if (usb_irq == NO_IRQ) {
> > drivers/usb/host/ohci-ppc-of.c:       if (irq == NO_IRQ) {
> > drivers/usb/host/uhci-grlib.c:        if (irq == NO_IRQ) {
> > drivers/video/fbdev/mb862xx/mb862xxfbdrv.c:   if (par->irq == NO_IRQ) {
> > drivers/virt/fsl_hypervisor.c:                if (!handle || (irq == NO_IRQ)) {
> > include/soc/fsl/qe/qe_ic.h:   if (cascade_irq != NO_IRQ)

None of these are used on ARM at the moment (as of linux-next yesterday),
they would have shown up in my randconfig tests otherwise.

The "qe" stuff is the only thing that will likely get used on ARM
in the future, but the usage of NO_IRQ in that driver is actually
wrong on ARM, so that has to be fixed anyway before we can use it.

	Arnd


More information about the Linuxppc-dev mailing list