[PATCH v2 4/5] powerpc/fadump: Make ELF eflags depend on endian

Michael Ellerman mpe at ellerman.id.au
Thu Sep 8 19:17:38 AEST 2016


Mahesh Jagannath Salgaonkar <mahesh at linux.vnet.ibm.com> writes:

> On 09/06/2016 11:02 AM, Daniel Axtens wrote:
>> diff --git a/arch/powerpc/kernel/fadump.c b/arch/powerpc/kernel/fadump.c
>> index 0638b82ce294..457f08e544c6 100644
>> --- a/arch/powerpc/kernel/fadump.c
>> +++ b/arch/powerpc/kernel/fadump.c
>> @@ -779,7 +779,11 @@ static int fadump_init_elfcore_header(char *bufp)
>>  	elf->e_entry = 0;
>>  	elf->e_phoff = sizeof(struct elfhdr);
>>  	elf->e_shoff = 0;
>> -	elf->e_flags = ELF_CORE_EFLAGS;
>> +#ifdef __LITTLE_ENDIAN__
>
> Wouldn't '#ifdef PPC64_ELF_ABI_v2' be more appropriate here ?

Yes! I forgot we had added that and told Daniel to use LITTLE_ENDIAN.

I'll fix it up when I apply it.

cheers


More information about the Linuxppc-dev mailing list