Build regression introduced by 31cdd0c39c7544ced79da53aa0b7e989f3a39582

Paul Mackerras paulus at ozlabs.org
Wed Sep 7 11:23:56 AEST 2016


On Tue, Sep 06, 2016 at 11:01:02PM +0200, John Paul Adrian Glaubitz wrote:
> Hi Paul!
> 
> I'm referring to your change [1]:
> 
> "powerpc/xmon: Fix SPR read/write commands and add command to dump SPRs"
> 
> which introduced assembly code in the new file arch/powerpc/xmon/spr_access.S.
> 
> Unfortunately, this code contains assembly instructions which are not available on
> all ppc targets. In particular, this change breaks the build on PPC e500v2 targets,
> see the corresponding Debian bug report [2].
> 
> Could you have a look and possibly add some guarding #ifdefs for the ppc targets
> where "ld" is not a supported instruction?

I blame Michael. :)  My original version of the patch didn't have the
ld instructions, and then Michael did a v2 that was different.  He
didn't update the patch description so I don't know exactly why he
changed that.  I'll discuss it with him.

Paul.


More information about the Linuxppc-dev mailing list