[PATCH] Fix "ibm,processor-radix-AP-encodings"

Michael Ellerman mpe at ellerman.id.au
Tue Oct 11 16:47:50 AEDT 2016


Oliver O'Halloran <oohall at gmail.com> writes:

> On Wed, Sep 28, 2016 at 12:43 PM, Aneesh Kumar K.V
> <aneesh.kumar at linux.vnet.ibm.com> wrote:
>> Balbir Singh <bsingharora at gmail.com> writes:
>>
>>> The top 3 bits of the lower order byte should contain the
>>> AP encoding, we assume the top 3 bits of the MSB.
>
> Balbir, could you reword this so it says "Currently we wrongly assume
> <blah>" or similar. The current commit message made me think you were
> changing it to look at the top 3 bits of the MSB rather than changing
> it look at the LSB.

Yeah please reword it to describe what the current code does, why it's
incorrect, and how we are fixing it.

cheers


More information about the Linuxppc-dev mailing list