[1/9] powerpc/powernv: Pass CPU-endian PE number to opal_pci_eeh_freeze_clear()
Michael Ellerman
patch-notifications at ellerman.id.au
Wed Oct 5 13:36:25 AEDT 2016
On Tue, 2016-02-08 at 04:10:29 UTC, Gavin Shan wrote:
> The PE number (@frozen_pe_no), filled by opal_pci_next_error() is in
> big-endian format. It should be converted to CPU-dian before it is
> passed to opal_pci_eeh_freeze_clear() when clearing the frozen state
> if the PE is invalid one. As Michael Ellerman pointed out, the issue
> is also detected by sparse:
>
> gwshan at gwshan:~/sandbox/l$ make C=2 CF=-D__CHECK_ENDIAN__ \
> arch/powerpc/platforms/powernv/eeh-powernv.o
> :
> arch/powerpc/platforms/powernv/eeh-powernv.c:1541:41: \
> warning: incorrect type in argument 2 (different base types)
> arch/powerpc/platforms/powernv/eeh-powernv.c:1541:41: \
> expected unsigned long long [unsigned] [usertype] pe_number
> arch/powerpc/platforms/powernv/eeh-powernv.c:1541:41: \
> got restricted __be64 [addressable] [usertype] frozen_pe_no
>
> This passes CPU-endian PE number to opal_pci_eeh_freeze_clear() and
> it should be part of commit <0f36db77643b> ("powerpc/eeh: Fix wrong
> printed PE number"), which was merged to 4.3 kernel.
>
> Fixes: 71b540adffd9 ("powerpc/powernv: Don't escalate non-existing frozen PE")
> Cc: stable at vger.kernel.org # v4.3+
> Suggested-by: Paul Mackerras <paulus at samba.org>
> Signed-off-by: Gavin Shan <gwshan at linux.vnet.ibm.com>
> Reviewed-by: Russell Currey <ruscur at russell.cc>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/d63e51b31e0b655ed0f581b8a8fd4c
cheers
More information about the Linuxppc-dev
mailing list