[1/3] powerpc/64e: convert cmpi to cmpwi in head_64.S

Michael Ellerman patch-notifications at ellerman.id.au
Tue Nov 29 23:58:11 AEDT 2016


On Wed, 2016-11-23 at 13:02:07 UTC, Nicholas Piggin wrote:
> >From 80f23935cadb ("powerpc: Convert cmp to cmpd in idle enter sequence"):
> 
>     PowerPC's "cmp" instruction has four operands. Normally people write
>     "cmpw" or "cmpd" for the second cmp operand 0 or 1. But, frequently
>     people forget, and write "cmp" with just three operands.
> 
>     With older binutils this is silently accepted as if this was "cmpw",
>     while often "cmpd" is wanted. With newer binutils GAS will complain
>     about this for 64-bit code. For 32-bit code it still silently assumes
>     "cmpw" is what is meant.
> 
>     In this instance the code comes directly from ISA v2.07, including the
>     cmp, but cmpd is correct. Backport to stable so that new toolchains can
>     build old kernels.
> 
> In this case, cmpwi is called for, so this is just a build fix for
> new toolchians.
> 
> Stable: v3.0
> Cc: Segher Boessenkool <segher at kernel.crashing.org>
> Signed-off-by: Nicholas Piggin <npiggin at gmail.com>

Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/f87f253bac3ce4a4eb2a60a1ae604d

cheers


More information about the Linuxppc-dev mailing list