[PATCH 4/7] powerpc/64: tool to check head sections location sanity

Michael Ellerman mpe at ellerman.id.au
Tue Nov 22 16:56:04 AEDT 2016


Nicholas Piggin <npiggin at gmail.com> writes:
> On Tue, 15 Nov 2016 11:55:26 +1100
> Michael Ellerman <mpe at ellerman.id.au> wrote:
>> Nicholas Piggin <npiggin at gmail.com> writes:
>> > diff --git a/arch/powerpc/tools/head_check.sh b/arch/powerpc/tools/head_check.sh
>> > new file mode 100755
>> > index 0000000..9635fe7
>> > --- /dev/null
>> > +++ b/arch/powerpc/tools/head_check.sh
>> > @@ -0,0 +1,69 @@
>> > +#!/bin/sh  
>> 
>> We run this explicitly via $(CONFIG_SHELL), so having a shebang here is
>> redundant and also a little confusing. I added "-x" here, to turn on
>> tracing, but it doesn't take effect, so I think better to just drop the
>> line. If anyone wants to run it manually they can just pass it to sh.
>
> Okay. How about relocs_check.sh? I just started by copying that.

Yeah may as well fix it too. 

>> # Turn this on if you want more debug output:
>> # set -x
>
> Can do, same question applies for relocs_check.sh

Yep, save the next person who's debugging it the time.

cheers


More information about the Linuxppc-dev mailing list