[PATCH v3 4/6] powerpc/mm/hugetlb: Switch hugetlb update to use huge_pte_update

Michael Ellerman mpe at ellerman.id.au
Tue Nov 22 13:41:09 AEDT 2016


"Aneesh Kumar K.V" <aneesh.kumar at linux.vnet.ibm.com> writes:

> We want to switch pte_update to use va based tlb flush. In order to do that we
> need to track the page size. With hugetlb we currently don't have page size
> available in these functions. Hence switch hugetlb to use seperate functions
> for update. In later patch we will update hugetlb functions to take
> vm_area_struct from which we can derive the page size. After that we will switch
> this back to use pte_update

This breaks corenet64_smp_defconfig:

In file included from ../arch/powerpc/include/asm/page.h:294:0,
                 from ../arch/powerpc/include/asm/thread_info.h:34,
                 from ../include/linux/thread_info.h:58,
                 from ../include/asm-generic/preempt.h:4,
                 from ./arch/powerpc/include/generated/asm/preempt.h:1,
                 from ../include/linux/preempt.h:59,
                 from ../include/linux/spinlock.h:50,
                 from ../include/linux/mmzone.h:7,
                 from ../include/linux/gfp.h:5,
                 from ../arch/powerpc/mm/pgtable.c:25:
../arch/powerpc/include/asm/hugetlb.h: In function ‘huge_ptep_get_and_clear’:
../arch/powerpc/include/asm/hugetlb.h:139:15: error: implicit declaration of function ‘huge_pte_update’ [-Werror=implicit-function-declaration]
  return __pte(huge_pte_update(mm, addr, ptep, ~0UL, 0));
               ^
../arch/powerpc/include/asm/pgtable-types.h:6:30: note: in definition of macro ‘__pte’
 #define __pte(x) ((pte_t) { (x) })


And many more.

cheers


More information about the Linuxppc-dev mailing list