[PATCH] powerpc/xmon: Add support for dump in reverse

[Michael Ellerman]

Balbir Singh <bsingharora at gmail.com> writes:

> On 18/11/16 13:02, kbuild test robot wrote:
>> Hi Balbir,
>> 
>> [auto build test ERROR on powerpc/next]
>> [also build test ERROR on v4.9-rc5 next-20161117]
>> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
>> 
>> url:    https://github.com/0day-ci/linux/commits/Balbir-Singh/powerpc-xmon-Add-support-for-dump-in-reverse/20161118-081358
>> base:   https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next
>> config: powerpc-ppc64e_defconfig (attached as .config)
>> compiler: powerpc64-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705
>> reproduce:
>>         wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
>>         chmod +x ~/bin/make.cross
>>         # save the attached .config to linux build tree
>>         make.cross ARCH=powerpc 
>> 
>> Note: it may well be a FALSE warning. FWIW you are at least aware of it now.
>> http://gcc.gnu.org/wiki/Better_Uninitialized_Warnings
>> 
>> All errors (new ones prefixed by >>):
>> 
>>    arch/powerpc/xmon/xmon.c: In function 'prdump':
>>>> arch/powerpc/xmon/xmon.c:2431:10: error: 'idx' may be used uninitialized in this function [-Werror=maybe-uninitialized]
>>          idx -= 2;
>>          ~~~~^~~~
>>    cc1: all warnings being treated as errors
>> 
>> vim +/idx +2431 arch/powerpc/xmon/xmon.c
>> 
>>   2425				}
>>   2426	
>>   2427				if (m < nr) {
>>   2428					if (reverse) {
>>   2429						buf[idx + 1] = digithex(temp[m] % 16);
>>   2430						buf[idx] = digithex(temp[m] / 16);
>>> 2431						idx -= 2;
>>   2432					} else
>>   2433						printf("%.2x", temp[m]);
>>   2434				} else
>> 
>
> This seems like a false positive, I don't see it with gcc 5.3.1 on my system. I also tried with gcc 6.2.0
> I tried with the same config as attached with the email in the reported failure. I'll try to get the debian
> 6.1.1 compiler and see how that goes.

Actually I want you to rework the patch anyway :)

Will talk tomorrow.

cheers