[PATCH] ibmebus: Remove legacy suspend/resume support

[Lars-Peter Clausen]

On 11/21/2016 10:52 AM, Michael Ellerman wrote:
> Lars-Peter Clausen <lars at metafoo.de> writes:
> 
>> There are no ibmebus driver that make use of legacy suspend/resume. This
>> patch removes the support for it from ibmebus framework, new ibmebus driver
>> (as unlikely as they are) wanting to use suspend/resume should use
>> dev_pm_ops.
>>
>> Since there aren't any special bus specific things to do during
>> suspend/resume and since the PM core will automatically fallback directly
>> to using the device's PM ops if no bus PM ops are specified there is no
>> need to have any special ibmebus PM ops at all.
> 
> Thanks, this looks like a really nice cleanup.
> 
> I don't know the PM code at all, is there any down side to removing all
> of this?

No, dev_pm_op is a full replacement for the legacy suspend/resume callbacks
and dev_pm_ops are supported by the power management core out of the box
without having to have any bus specific code. Which is why we want to get
rid of legacy PM callbacks in general and this is one of the last few buses
that still implements it. But since there are no drivers that use it
removing it is straight forward in this case, for others it takes a bit more
work.