[1/2, v3] Revert "powerpc/eeh: Fix crash in eeh_add_device_early() on Cell"
mpe at ellerman.id.au
Thu May 12 21:32:39 AEST 2016
On Mon, 2016-11-04 at 19:17:22 UTC, "Guilherme G. Piccoli" wrote:
> This reverts commit 89a51df5ab1d38b257300b8ac940bbac3bb0eb9b.
> The function eeh_add_device_early() is used to perform EEH initialization in
> devices added later on the system, like in hotplug/DLPAR scenarios. Since the
> commit 89a51df5ab1d ("powerpc/eeh: Fix crash in eeh_add_device_early() on Cell")
> a new check was introduced in this function - Cell has no EEH capabilities
> which led to kernel oops if hotplug was performed, so checking for
> eeh_enabled() was introduced to avoid the issue.
> However, in architectures that EEH is present like pSeries or PowerNV, we might
> reach a case in which no PCI devices are present on boot time and so EEH is not
> initialized. Then, if a device is added via DLPAR for example,
> eeh_add_device_early() fails because eeh_enabled() is false, and EEH end up
> not being enabled at all.
> This reverts the aforementioned patch since a new verification was introduced by
> the commit d91dafc02f42 ("powerpc/eeh: Delay probing EEH device during hotplug")
> and so the original Cell issue does not happen anymore.
> Cc: stable at vger.kernel.org
> Reviewed-by: Gavin Shan <gwshan at linux.vnet.ibm.com>
> Signed-off-by: Guilherme G. Piccoli <gpiccoli at linux.vnet.ibm.com>
Applied to powerpc next, thanks.
More information about the Linuxppc-dev