[PATCH 2/2] Deduplicate the actual base page size code

Aneesh Kumar K.V aneesh.kumar at linux.vnet.ibm.com
Wed May 11 11:45:39 AEST 2016


Balbir Singh <bsingharora at gmail.com> writes:

> On 11/05/16 04:09, Aneesh Kumar K.V wrote:
>> Balbir Singh <bsingharora at gmail.com> writes:
>> 
>>> Deduplicate to one function to compute the actual page size.
>>> Some additional warnings added for AP size as well.
>> 
>> 
>> This is getting chaned in a cleanup series I am testing before posting. 
>> The change from ap to psize need more update in commit message. 
>> 
>> commit 701e0d3dc33c93a97b825f403d58f6be99b89203
>> Author: Aneesh Kumar K.V <aneesh.kumar at linux.vnet.ibm.com>
>> Date:   Tue May 10 11:33:15 2016 +0530
>> 
>>     powerpc/mm/radix/hugetlb: Add helper for finding page size from hstate
>>     
>>     Use the helper instead of open coding the same at multiple place
>>     
>>     Signed-off-by: Aneesh Kumar K.V <aneesh.kumar at linux.vnet.ibm.com>
>
> This version makes more sense. While we are at it, mind replacing psize with base_psize and asserting
> that base_psize is always 0 or 5.
>

With radix config there is no base/actual page size. The new function is
returning MMU_PAGE_* values and not the AP encoding.

-aneesh



More information about the Linuxppc-dev mailing list