[PATCH 02/65] powerpc/mm: use _PAGE_READ to indicate Read access

Ian Munsie imunsie at au1.ibm.com
Mon Mar 28 02:35:35 AEDT 2016


I'll leave it to others to work out whether the general approach & code
in /arch/powerpc is right, but at least for the cxl driver:

Acked-by: Ian Munsie <imunsie at au1.ibm.com>

Excerpts from Aneesh Kumar K.V's message of 2016-03-27 03:23:10 -0500:
> diff --git a/drivers/misc/cxl/fault.c b/drivers/misc/cxl/fault.c
> index 81c3f75b7330..a3d5e1e16c21 100644
> --- a/drivers/misc/cxl/fault.c
> +++ b/drivers/misc/cxl/fault.c
> @@ -149,9 +149,9 @@ static void cxl_handle_page_fault(struct cxl_context *ctx,
>       * update_mmu_cache() will not have loaded the hash since current->trap
>       * is not a 0x400 or 0x300, so just call hash_page_mm() here.
>       */
> -    access = _PAGE_PRESENT;
> +    access = _PAGE_PRESENT | _PAGE_READ;
>      if (dsisr & CXL_PSL_DSISR_An_S)
> -        access |= _PAGE_RW;
> +        access |= _PAGE_WRITE;
>      if ((!ctx->kernel) || ~(dar & (1ULL << 63)))
>          access |= _PAGE_USER;



More information about the Linuxppc-dev mailing list