[PATCH v2 4/6] powerpc: mm: Use hugetlb_bad_size

Vaishali Thakkar vaishali.thakkar at oracle.com
Wed Mar 23 23:34:27 AEDT 2016


Update the setup_hugepagesz function to call the routine
hugetlb_bad_size when unsupported hugepage size is found.

Misc:
   - Silent checkpatch.pl's 80 characters and printk warning

Signed-off-by: Vaishali Thakkar <vaishali.thakkar at oracle.com>
Reviewed-by: Mike Kravetz <mike.kravetz at oracle.com>
Reviewed-by: Naoya Horiguchi <n-horiguchi at ah.jp.nec.com>
Cc: Hillf Danton <hillf.zj at alibaba-inc.com>
Cc: Michal Hocko <mhocko at suse.com>
Cc: Yaowei Bai <baiyaowei at cmss.chinamobile.com>
Cc: Dominik Dingel <dingel at linux.vnet.ibm.com>
Cc: Kirill A. Shutemov <kirill.shutemov at linux.intel.com>
Cc: Paul Gortmaker <paul.gortmaker at windriver.com>
Cc: Dave Hansen <dave.hansen at linux.intel.com>
---
Please note that the patch is tested for x86 only. But as this
is one line change I just changed them. So, it would be good if
the patch can be tested for other architectures before adding
this in to mainline.
Changes since v1:
        - Separate different arch specific changes in different
          patches instead of one
---
 arch/powerpc/mm/hugetlbpage.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/arch/powerpc/mm/hugetlbpage.c b/arch/powerpc/mm/hugetlbpage.c
index 6dd272b..3e5e128 100644
--- a/arch/powerpc/mm/hugetlbpage.c
+++ b/arch/powerpc/mm/hugetlbpage.c
@@ -772,8 +772,10 @@ static int __init hugepage_setup_sz(char *str)
 
 	size = memparse(str, &str);
 
-	if (add_huge_page_size(size) != 0)
-		printk(KERN_WARNING "Invalid huge page size specified(%llu)\n", size);
+	if (add_huge_page_size(size) != 0) {
+		hugetlb_bad_size();
+		pr_err("Invalid huge page size specified(%llu)\n", size);
+	}
 
 	return 1;
 }
-- 
2.1.4



More information about the Linuxppc-dev mailing list