[PATCH v8 3/6] cpufreq: powernv: Remove cpu_to_chip_id() from hot-path
Michael Neuling
mikey at neuling.org
Sat Mar 19 10:20:21 AEDT 2016
On Sat, 2016-03-19 at 09:37 +1100, Benjamin Herrenschmidt wrote:
> On Fri, 2016-03-18 at 15:04 +1100, Michael Neuling wrote:
> >
> > static int nr_chips;
> > +static DEFINE_PER_CPU(unsigned int, chip_id);
> >
> > /*
> > * Note: The set of pstates consists of contiguous integers, the
> > @@ -317,9 +318,7 @@ static void powernv_cpufreq_throttle_check(void
> > *data)
> >
> > pmsr = get_pmspr(SPRN_PMSR);
> >
> > - for (i = 0; i < nr_chips; i++)
> > - if (chips[i].id == cpu_to_chip_id(cpu))
> > - break;
> > + i = this_cpu_read(chip_id);
>
> Except it's not a chip_id, so your patch confused me for a good 2mn
> ...
> Call it chip_idx maybe ? ie, index.
Yeah, it was a badly named variable but I changed it even more and
Shilpasri rebased it here:
http://patchwork.ozlabs.org/patch/599523/
Mikey
More information about the Linuxppc-dev
mailing list