> +static int read_vpd(struct cxl *adapter, struct cxl_afu *afu) ... > + if (rc > 0) { > + cxl_dump_debug_buffer(vpd, rc); Much nicer than including all that inline - thanks :) Acked-by: Ian Munsie <imunsie at au1.ibm.com>