[1/4] powerpc/mm: Clean up error handling for htab_remove_mapping
Michael Ellerman
mpe at ellerman.id.au
Wed Mar 2 09:21:18 AEDT 2016
On Tue, 2016-09-02 at 03:32:40 UTC, David Gibson wrote:
> Currently, the only error that htab_remove_mapping() can report is -EINVAL,
> if removal of bolted HPTEs isn't implemeted for this platform. We make
> a few clean ups to the handling of this:
>
> * EINVAL isn't really the right code - there's nothing wrong with the
> function's arguments - use ENODEV instead
> * We were also printing a warning message, but that's a decision better
> left up to the callers, so remove it
> * One caller is vmemmap_remove_mapping(), which will just BUG_ON() on
> error, making the warning message redundant, so no change is needed
> there.
> * The other caller is remove_section_mapping(). This is called in the
> memory hot remove path at a point after vmemmap_remove_mapping() so
> if hpte_removebolted isn't implemented, we'd expect to have already
> BUG()ed anyway. Put a WARN_ON() here, in lieu of a printk() since this
> really shouldn't be happening.
>
> Signed-off-by: David Gibson <david at gibson.dropbear.id.au>
> Reviewed-by: Aneesh Kumar K.V <aneesh.kumar at linux.vnet.ibm.com>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/abd0a0e7914a1137973119ac3b
cheers
More information about the Linuxppc-dev
mailing list