[RFC PATCH 1/2] KVM: PPC: divide the ics lock into smaller ones for each irq

Paul Mackerras paulus at ozlabs.org
Mon Jun 20 15:25:13 AEST 2016


On Mon, May 16, 2016 at 02:58:18PM +0800, Li Zhong wrote:
> This patch tries to use smaller locks for each irq in the ics, instead
> of a lock at the ics level, to provide better scalability.

This looks like a worth-while thing to do.  Do you have any
performance measurements to justify the change?  This will increase
the size of struct kvmppc_ics by 4kB, so it would be useful to show
the performance increase that justifies it.

Also, when you resend the patch, please make the patch description
more definite - say "With this patch, we use" rather than "this patch
tries to use", for instance.

Regards,
Paul.


More information about the Linuxppc-dev mailing list