[PATCH] tools include: Fix wrong macro definitions for cpu_to_le* for big endian
He Kuang
hekuang at huawei.com
Thu Jun 16 11:27:06 AEST 2016
From: Wang Nan <wangnan0 at huawei.com>
The cpu_to_le* macros in kernel.h are defined without considering
endianese. This patch includes "byteoder/generic.h" instead to fix the
bug, and removes redundant le64_to_cpu definition in intel-bts.c.
Signed-off-by: Wang Nan <wangnan0 at huawei.com>
Signed-off-by: He Kuang <hekuang at huawei.com>
---
tools/include/linux/kernel.h | 5 ++---
tools/perf/util/intel-bts.c | 5 -----
2 files changed, 2 insertions(+), 8 deletions(-)
diff --git a/tools/include/linux/kernel.h b/tools/include/linux/kernel.h
index 76df535..6145e41 100644
--- a/tools/include/linux/kernel.h
+++ b/tools/include/linux/kernel.h
@@ -64,11 +64,10 @@
#endif
/*
- * Both need more care to handle endianness
+ * Need more care to handle endianness
* (Don't use bitmap_copy_le() for now)
*/
-#define cpu_to_le64(x) (x)
-#define cpu_to_le32(x) (x)
+#include <linux/byteorder/generic.h>
static inline int
vscnprintf(char *buf, size_t size, const char *fmt, va_list args)
diff --git a/tools/perf/util/intel-bts.c b/tools/perf/util/intel-bts.c
index 9df9960..0e632c4 100644
--- a/tools/perf/util/intel-bts.c
+++ b/tools/perf/util/intel-bts.c
@@ -40,11 +40,6 @@
#define INTEL_BTS_ERR_NOINSN 5
#define INTEL_BTS_ERR_LOST 9
-#if __BYTE_ORDER == __BIG_ENDIAN
-#define le64_to_cpu bswap_64
-#else
-#define le64_to_cpu
-#endif
struct intel_bts {
struct auxtrace auxtrace;
--
1.8.3.4
More information about the Linuxppc-dev
mailing list