[PATCH] powerpc/pseries: Add POWER8NVL support to ibm,client-architecture-support call

Michael Ellerman mpe at ellerman.id.au
Wed Jun 8 21:27:22 AEST 2016


On Wed, 2016-06-08 at 13:17 +0200, Thomas Huth wrote:
> On 08.06.2016 12:44, Michael Ellerman wrote:
> > On Wed, 2016-06-08 at 11:14 +1000, Balbir Singh wrote:
> > > Don't we need to update IBM_ARCH_VEC_NRCORES_OFFSET as well?
> > 
> > Yep, patch sent this morning.
> 
> Ok, looks like BenH already posted a patch ...

And me before him :)

To be clear I'm not blaming you in any way for this, the existing code is
terrible and incredibly fragile.

> anyway, what do you think about aborting the boot process here in case cores
> != NR_CPUS, rather than just printing out a small warning which can easily get
> lost in the kernel log?

Yeah I agree it's easy to miss. And it's not part of dmesg (because it's from
prom_init()), so you *only* see it if you're actually staring at the console as
it boots (which is why my boot tests missed it).

I actually have plans to rewrite the whole thing to make it robust, so that
should avoid it ever being a problem again.

cheers



More information about the Linuxppc-dev mailing list