[PATCH] of: fix autoloading due to broken modalias with no 'compatible'
Wolfram Sang
wsa at the-dreams.de
Tue Jun 7 02:48:38 AEST 2016
Because of an improper dereference, a stray 'C' character was output to
the modalias when no 'compatible' was specified. This is the case for
some old PowerMac drivers which only set the 'name' property. Fix it to
let them match again.
Reported-by: Mathieu Malaterre <malat at debian.org>
Signed-off-by: Wolfram Sang <wsa at the-dreams.de>
Tested-by: Mathieu Malaterre <malat at debian.org>
Cc: Philipp Zabel <p.zabel at pengutronix.de>
Cc: Andreas Schwab <schwab at linux-m68k.org>
Fixes: 6543becf26fff6 ("mod/file2alias: make modalias generation safe for cross compiling")
---
I think it makes sense if this goes in via ppc (with stable tag added).
D'accord?
scripts/mod/file2alias.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/mod/file2alias.c b/scripts/mod/file2alias.c
index a9155077feefb9..fec75786f75bbb 100644
--- a/scripts/mod/file2alias.c
+++ b/scripts/mod/file2alias.c
@@ -384,7 +384,7 @@ static void do_of_entry_multi(void *symval, struct module *mod)
len = sprintf(alias, "of:N%sT%s", (*name)[0] ? *name : "*",
(*type)[0] ? *type : "*");
- if (compatible[0])
+ if ((*compatible)[0])
sprintf(&alias[len], "%sC%s", (*type)[0] ? "*" : "",
*compatible);
--
2.8.1
More information about the Linuxppc-dev
mailing list