[RFC v3 22/45] powerpc: dma-mapping: Use unsigned long for dma_attrs

Krzysztof Kozlowski k.kozlowski at samsung.com
Fri Jun 3 22:39:00 AEST 2016


On 06/03/2016 01:56 PM, Michael Ellerman wrote:
> On Thu, 2016-06-02 at 17:39 +0200, Krzysztof Kozlowski wrote:
> 
>> diff --git a/arch/powerpc/platforms/cell/iommu.c b/arch/powerpc/platforms/cell/iommu.c
>> index 0c2794d2b6c0..5d1a7ef3fdee 100644
>> --- a/arch/powerpc/platforms/cell/iommu.c
>> +++ b/arch/powerpc/platforms/cell/iommu.c
>> @@ -166,7 +166,7 @@ static void invalidate_tce_cache(struct cbe_iommu *iommu, unsigned long *pte,
>>  
>>  static int tce_build_cell(struct iommu_table *tbl, long index, long npages,
>>  		unsigned long uaddr, enum dma_data_direction direction,
>> -		struct dma_attrs *attrs)
>> +		unsigned long attrs)
>>  {
>>  	int i;
>>  	unsigned long *io_pte, base_pte;
> 
> You missed the call site:

Right, thanks!

Best regards,
Krzysztof

> diff --git a/arch/powerpc/platforms/cell/iommu.c b/arch/powerpc/platforms/cell/iommu.c
> index 2018e562d124..6128bdb428b2 100644
> --- a/arch/powerpc/platforms/cell/iommu.c
> +++ b/arch/powerpc/platforms/cell/iommu.c
> @@ -526,7 +526,7 @@ cell_iommu_setup_window(struct cbe_iommu *iommu, struct device_node *np,
>  
>  	__set_bit(0, window->table.it_map);
>  	tce_build_cell(&window->table, window->table.it_offset, 1,
> -		       (unsigned long)iommu->pad_page, DMA_TO_DEVICE, NULL);
> +		       (unsigned long)iommu->pad_page, DMA_TO_DEVICE, 0);
>  
>  	return window;
>  }
> 
> 
> cheers
> 
> 
> 



More information about the Linuxppc-dev mailing list