[PATCH] Make system_reset_pSeries relocatable

Nicholas Piggin npiggin at gmail.com
Wed Jul 27 21:51:15 AEST 2016


On Wed, 27 Jul 2016 20:01:24 +1000
Balbir Singh <bsingharora at gmail.com> wrote:

> On Wed, Jul 27, 2016 at 7:53 PM, Benjamin Herrenschmidt
> <benh at kernel.crashing.org> wrote:
> > On Wed, 2016-07-27 at 17:32 +1000, Balbir Singh wrote:  
> >> From: Balbir Singh <bsingharora at gmail.com>
> >>
> >> Currently the power management bits are broken w.r.t. relocation.
> >> There are direct branches from system_reset_pSeries to
> >> power7_wakeup_*.  
> >
> > Side track: we should really get rid of the _pSeries suffix for
> > these things :-)
> >  
> 
> I thought about it, but then thought it would need more auditing
> across places and hence held back. I'll be happy to send another patch
> to remove _pSeries from the exception-64s.S to begin with as a follow
> up

Ahh, my patches do that actually. Not as a primary concern, but
I removed almost all labels and naming from the exception-64s.h file,
and moved them into new head-64.h, so I changed the names a little
in the process.

It would be helpful to not touching this too much before we have some
more discussion of my reworking. I'm happy to rebase my stuff on top of
bugfixes though, of course.

Thanks,
Nick


More information about the Linuxppc-dev mailing list