[PATCH v11 4/5] powerpc/fsl: move mpc85xx.h to include/linux/fsl

Michael Ellerman mpe at ellerman.id.au
Thu Jul 21 20:26:06 AEST 2016


Quoting Scott Wood (2016-07-21 04:31:48)
> On Wed, 2016-07-20 at 13:24 +0200, Arnd Bergmann wrote:
> > On Saturday, July 16, 2016 9:50:21 PM CEST Scott Wood wrote:
> > > 
> > > From: yangbo lu <yangbo.lu at nxp.com>
> > > 
> > > Move mpc85xx.h to include/linux/fsl and rename it to svr.h as a common
> > > header file.  This SVR numberspace is used on some ARM chips as well as
> > > PPC, and even to check for a PPC SVR multi-arch drivers would otherwise
> > > need to ifdef the header inclusion and all references to the SVR symbols.
> > > 
> > > Signed-off-by: Yangbo Lu <yangbo.lu at nxp.com>
> > > Acked-by: Wolfram Sang <wsa at the-dreams.de>
> > > Acked-by: Stephen Boyd <sboyd at codeaurora.org>
> > > Acked-by: Joerg Roedel <jroedel at suse.de>
> > > [scottwood: update description]
> > > Signed-off-by: Scott Wood <oss at buserror.net>
> > > 
> > As discussed before, please don't introduce yet another vendor specific
> > way to match a SoC ID from a device driver.
> > 
> > I've posted a patch for an extension to the soc_device infrastructure
> > to allow comparing the running SoC to a table of devices, use that
> > instead.
> 
> As I asked before, in which relevant maintainership capacity are you NACKing
> this?

I'll nack the powerpc part until you guys can agree.

cheers


More information about the Linuxppc-dev mailing list