powerpc/crash: Rearrange loop condition to avoid out of bounds array access

Michael Ellerman mpe at ellerman.id.au
Fri Jul 15 20:53:43 AEST 2016

On Mon, 2016-11-07 at 04:17:31 UTC, Suraj Jitindar Singh wrote:
> The array crash_shutdown_handles[] has size CRASH_HANDLER_MAX, thus when
> we loop over the elements of the list we check crash_shutdown_handles[i]
> && i < CRASH_HANDLER_MAX. However this means that when we increment i to
> CRASH_HANDLER_MAX we will perform an out of bound array access checking
> the first condition before exiting on the second condition.
> To avoid the out of bounds access, simply reorder the loop conditions.
> Signed-off-by: Suraj Jitindar Singh <sjitindarsingh at gmail.com>
> Reviewed-by: Andrew Donnellan <andrew.donnellan at au1.ibm.com>

Applied to powerpc next, thanks.



More information about the Linuxppc-dev mailing list