[PATCH v3 3/4] perf annotate: add powerpc support

Michael Ellerman mpe at ellerman.id.au
Wed Jul 13 17:39:01 AEST 2016


Arnaldo Carvalho de Melo <acme at kernel.org> writes:

> Em Tue, Jul 12, 2016 at 07:51:46AM +0530, Ravi Bangoria escreveu:
>> Hi Arnaldo,
>> 
>> On Friday 08 July 2016 02:01 PM, Michael Ellerman wrote:
>> > Ravi Bangoria <ravi.bangoria at linux.vnet.ibm.com> writes:
>> > 
>> > > On Wednesday 06 July 2016 03:38 PM, Michael Ellerman wrote:
>> > > 
>> > > I've sent v4 which enables annotate for bctr' instructions.
>> > > 
>> > > for 'bctr', it will show down arrow(indicate jump) and 'bctrl' will show
>> > > right arrow(indicate call). But no navigation options will be provided.
>> > > By pressing Enter key on that, message will be shown that like
>> > > "Invalid target"
>> > Great thanks.
>> 
>> I've sent v4 series. Please review it.
>
> If somebody else could do it and provide acks/reviewed by, that would
> help,
>
> Michael, can I get your comments as such?

It looks OK to me. But I don't know the code really, and I haven't had
time to test it personally.

Ravi, have you tested on a big endian machine?

cheers


More information about the Linuxppc-dev mailing list