[PATCH V2 2/2] tty/hvc: Use opal irqchip interface if available

Michael Ellerman mpe at ellerman.id.au
Mon Jul 11 16:28:46 AEST 2016


Samuel Mendoza-Jonas <sam at mendozajonas.com> writes:

> Update the hvc driver to use the OPAL irqchip if made available by the
> running firmware. If it is not present, the driver falls back to the
> existing OPAL event number.
>
> Signed-off-by: Samuel Mendoza-Jonas <sam at mendozajonas.com>
> Cc: <stable at vger.kernel.org> # 4.1.x-
> ---
> v2: Always try irq_of_parse_and_map before falling back

LGTM.

Acked-by: Michael Ellerman <mpe at ellerman.id.au>

cheers

> diff --git a/drivers/tty/hvc/hvc_opal.c b/drivers/tty/hvc/hvc_opal.c
> index b7cd0ae..5107993 100644
> --- a/drivers/tty/hvc/hvc_opal.c
> +++ b/drivers/tty/hvc/hvc_opal.c
> @@ -214,7 +214,13 @@ static int hvc_opal_probe(struct platform_device *dev)
>  		dev->dev.of_node->full_name,
>  		boot ? " (boot console)" : "");
>  
> -	irq = opal_event_request(ilog2(OPAL_EVENT_CONSOLE_INPUT));
> +	irq = irq_of_parse_and_map(dev->dev.of_node, 0);
> +	if (!irq) {
> +		pr_info("hvc%d: No interrupts property, using OPAL event\n",
> +				termno);
> +		irq = opal_event_request(ilog2(OPAL_EVENT_CONSOLE_INPUT));
> +	}
> +
>  	if (!irq) {
>  		pr_err("hvc_opal: Unable to map interrupt for device %s\n",
>  			dev->dev.of_node->full_name);
> -- 
> 2.9.0


More information about the Linuxppc-dev mailing list