[PATCH v3 0/3] dma, nvme, powerpc: introduce and implement DMA_ATTR_NO_WARN
Mauricio Faria de Oliveira
mauricfo at linux.vnet.ibm.com
Fri Jul 8 22:27:05 AEST 2016
This patchset introduces dma_attr DMA_ATTR_NO_WARN (just like __GFP_NOWARN),
which tells the DMA-mapping subsystem to suppress allocation failure reports.
On some architectures allocation failures are reported with error messages
to the system logs. Although this can help to identify and debug problems,
drivers which handle failures (eg, retry later) have no problems with them,
and can actually flood the system logs with error messages that aren't any
problem at all, depending on the implementation of the retry mechanism.
So, this provides a way for drivers to avoid those error messages on calls
where allocation failures are not a problem, and shouldn't bother the logs.
- Patch 1/3 introduces and documents the new dma_attr.
- Patch 2/3 implements it on the nvme driver (which might repeatedly trip
on allocation failures due to high load, flooding system logs
with error messages at least on powerpc: "iommu_alloc failed")
- Patch 3/3 implements support for it on powerpc arch (where this problem
was observed. It's possible to extend support for more archs
if the patchset is welcome).
- nvme: use DMA_ATTR_NO_WARN when ret = BLK_MQ_RQ_QUEUE_BUSY (io will be
requeued) but not when ret = BLK_MQ_RQ_QUEUE_ERROR (io will be failed).
thanks: Masayoshi Mizuma <m.mizuma at jp.fujitsu.com>
- all: address warnings from checkpatch.pl (line wrapping and typos)
Mauricio Faria de Oliveira (3):
dma: introduce DMA_ATTR_NO_WARN
nvme: implement DMA_ATTR_NO_WARN
powerpc: implement DMA_ATTR_NO_WARN
Documentation/DMA-attributes.txt | 17 +++++++++++++++++
arch/powerpc/kernel/iommu.c | 6 ++++--
drivers/nvme/host/pci.c | 9 ++++++++-
include/linux/dma-attrs.h | 1 +
4 files changed, 30 insertions(+), 3 deletions(-)
More information about the Linuxppc-dev