[PATCH 02/41] drm: Fix broken use of _PAGE_NO_CACHE on powerpc

Michael Ellerman mpe at ellerman.id.au
Thu Jul 7 22:38:17 AEST 2016

Benjamin Herrenschmidt <benh at kernel.crashing.org> writes:

> That constant no longer exist. Use the proper accessor instead

I still see it?

  arch/powerpc/include/asm/book3s/32/hash.h:#define _PAGE_NO_CACHE	0x020	/* I: cache inhibit */
  arch/powerpc/include/asm/book3s/64/pgtable.h:#define _PAGE_NO_CACHE		_PAGE_TOLERANT
  arch/powerpc/include/asm/nohash/32/pte-44x.h:#define _PAGE_NO_CACHE	0x00000400		/* H: I bit */
  arch/powerpc/include/asm/nohash/32/pte-8xx.h:#define _PAGE_NO_CACHE	0x0002	/* I: cache inhibit */
  arch/powerpc/include/asm/nohash/32/pte-fsl-booke.h:#define _PAGE_NO_CACHE	0x00200	/* H: I bit */
  arch/powerpc/include/asm/nohash/pte-book3e.h:#define _PAGE_NO_CACHE	0x400000 /* I: cache inhibit */

Do you mean it doesn't exist in some cases? Or pgprot_noncached_wc() is
just better?

Also this should probably at least get Cc'ed to the DRM folks.


More information about the Linuxppc-dev mailing list