[RFC] Fix si->si_code for guard page access on PowerPC

Michael Ellerman mpe at ellerman.id.au
Wed Feb 24 20:39:23 AEDT 2016


Hi Gustavo,

On Fri, 2016-22-01 at 16:23:31 UTC, Gustavo Romero wrote:
> Fix si->si_code for guard page access on PowerPC
> 
...
> 
> diff --git a/arch/powerpc/mm/fault.c b/arch/powerpc/mm/fault.c
> index a67c6d7..6954971 100644
> --- a/arch/powerpc/mm/fault.c
> +++ b/arch/powerpc/mm/fault.c
> @@ -431,8 +431,10 @@ good_area:
>             */
>            fault = handle_mm_fault(mm, vma, address, flags);
>            if (unlikely(fault & (VM_FAULT_RETRY|VM_FAULT_ERROR))) {
> -                  if (fault & VM_FAULT_SIGSEGV)
> +                  if (fault & VM_FAULT_SIGSEGV) {
> +                           code = SEGV_MAPERR;
>                              goto bad_area;
> +                  }
>                     rc = mm_fault_error(regs, address, fault);
>                     if (rc >= MM_FAULT_RETURN)
>                              goto bail;


As we discussed on IRC, I'd prefer if this case was handled in
mm_fault_error(). So please send a v2 which does that, or let us know if you
have problems.

cheers


More information about the Linuxppc-dev mailing list