[RFC, kernel] powerpc/ioda: Set "read" permission when "write" is set

Alexey Kardashevskiy aik at ozlabs.ru
Wed Feb 17 18:29:10 AEDT 2016


On 02/16/2016 02:18 PM, Michael Ellerman wrote:
> On Tue, 2016-12-01 at 04:40:20 UTC, Alexey Kardashevskiy wrote:
>> Quite often drivers set only "write" permission assuming that this
>> includes "read" permission as well and this works on plenty platforms.
>> However IODA2 is strict about this and produces an EEH when "read"
>> permission is not and reading happens.
>>
>> This adds a workaround in IODA code to always add the "read" bit when
>> the "write" bit is set.
>>
>> Cc: Benjamin Herrenschmidt <benh at kernel.crashing.org>
>> Signed-off-by: Alexey Kardashevskiy <aik at ozlabs.ru>
>> Tested-by: Douglas Miller <dougmill at linux.vnet.ibm.com>
>
> Are you planning on sending a non-RFC version of this?

Just posted.

> If so is it an urgent fix I should send upstream now?

Yes.

 > And if so should it also be CC'ed to stable?

Ben suggested that yes, it should. Thanks. Sorry about breaking things.


-- 
Alexey


More information about the Linuxppc-dev mailing list