[PATCH] powerpc/eeh: Remove duplicated check in eeh_dump_pe_log()

Gavin Shan gwshan at linux.vnet.ibm.com
Tue Feb 16 10:30:26 AEDT 2016


On Mon, Feb 15, 2016 at 02:25:53PM +1100, Andrew Donnellan wrote:
>On 15/02/16 10:52, Gavin Shan wrote:
>>When eeh_dump_pe_log() is called in eeh_slot_error_detail(), we
>>already have the check that the PE isn't in PCI config blocked
>>state. So we needn't the duplicated check in eeh_dump_pe_log().
>>
>>This removes the duplicated check in eeh_dump_pe_log().
>>
>>Signed-off-by: Gavin Shan <gwshan at linux.vnet.ibm.com>
>
>eeh_dump_pe_log() isn't called anywhere outside of eeh_slot_error_detail(),
>so this should have no functional change.
>
>Reviewed-by: Andrew Donnellan <andrew.donnellan at au1.ibm.com>
>

Thanks for review. Do you want to see revised patch to include your
comments?

Thanks,
Gavin

>-- 
>Andrew Donnellan              Software Engineer, OzLabs
>andrew.donnellan at au1.ibm.com  Australia Development Lab, Canberra
>+61 2 6201 8874 (work)        IBM Australia Limited



More information about the Linuxppc-dev mailing list