[PATCH v3 12/18] cxl: Add guest-specific code

Ian Munsie imunsie at au1.ibm.com
Wed Feb 10 20:35:17 AEDT 2016


Reiterating the comment I made on the internal review, I would at some
point like to see an effort to refactor this and reduce the amount of
duplicated code between it and the native version, but that can come
later once this is in.

Acked-by: Ian Munsie <imunsie at au1.ibm.com>

Excerpts from Frederic Barrat's message of 2016-02-07 00:28:59 +1100:
> +static int read_vpd(struct cxl *adapter, struct cxl_afu *afu)
...
> +        buf = (u32 *) vpd;
> +        for (i = 0; i*4 < len; i += 4) {
> +            if ((i+3)*4 < len)
> +                pr_devel("%.8x %.8x %.8x %.8x\n",
> +                buf[i], buf[i + 1], buf[i + 2], buf[i + 3]);
> +            else if ((i+2)*4 < len)
> +                pr_devel("%.8x %.8x %.8x\n",
> +                buf[i], buf[i + 1], buf[i + 2]);
> +            else if ((i+1)*4 < len)
> +                pr_devel("%.8x %.8x\n",
> +                buf[i], buf[i + 1]);
> +            else
> +                pr_devel("%.8x\n", buf[i]);

Similar overly verbose debug print out like the I commented on in the
other patch.



More information about the Linuxppc-dev mailing list