[PATCH v2 0/4] powerpc/ps3: gelic_udbg: drop local versions of network data structs

Michael Ellerman mpe at ellerman.id.au
Tue Feb 9 13:54:12 AEDT 2016


On Mon, 2016-02-08 at 22:27 +0000, Luis Henriques wrote:

> Several network-related data structures are defined in gelic_udbg.
> These could be easily dropped and the standard ones defined in network
> headers could be used instead.
> 
> The 4 patches that follow replace ethernet, vlan, ip and udp
> structures in gelic_udbg.  Note that this has been compile-tested
> only.
> 
> Changes since v1:
> Include changes suggested by Joe Perches, namely the usage of
> eth_broadcast_addr(), ETH_ALEN, ETH_P_8021Q and ETH_P_IP.
> 
> Luis Henriques (4):
>   powerpc/ps3: gelic_udbg: use struct ethhdr from <linux/if_ether.h>
>   powerpc/ps3: gelic_udbg: use struct vlan_hdr from <linux/if_vlan.h>
>   powerpc/ps3: gelic_udbg: use struct iphdr from <linux/ip.h>
>   powerpc/ps3: gelic_udbg: use struct udphdr from <linux/udp.h>


These look good. But I don't have a setup to test them, does anyone?

I'll merge them and hopefully someone can test them at some point.

cheers



More information about the Linuxppc-dev mailing list