[PATCH 3/3] mtd/ifc: Segregate IFC fcm and runtime registers

Li Yang leoli at freescale.com
Tue Feb 2 06:41:45 AEDT 2016


On Mon, Feb 1, 2016 at 4:46 AM, Raghav Dogra <raghav at freescale.com> wrote:

A general comment is that you should include the linux-mtd mailing
list and it's maintainers for this set of patches.  Although the
MAINTAINERS file doesn't specify a maintainer for drivers/memory
directory, it should be most related to linux-mtd, IMO.

> IFC has two set of registers viz FCM (Flash control machine)
> aka global and run time registers. These set are defined in two
> memory map PAGES. Upto IFC 1.4 PAGE size is 4 KB and from IFC2.0
> PAGE size is 64KB

So I guess this patch is the critical change to make the fsl_ifc
driver work with the version 2.0 hardware block?  If so, it will be
better to mention this in the patch title.

>
> Signed-off-by: Jaiprakash Singh <b44839 at freescale.com>
> Signed-off-by: Raghav Dogra <raghav at freescale.com>
> ---
>  drivers/memory/fsl_ifc.c        | 251 +++++++++++++++++++++-------------------
>  drivers/mtd/nand/fsl_ifc_nand.c |  72 ++++++------
>  include/linux/fsl_ifc.h         |  48 +++++---
>  3 files changed, 203 insertions(+), 168 deletions(-)

Regards,
Leo


More information about the Linuxppc-dev mailing list