[RFCv2 4/9] arch/powerpc: Clean up memory hotplug failure paths

Anshuman Khandual khandual at linux.vnet.ibm.com
Mon Feb 1 17:29:25 AEDT 2016


On 01/29/2016 10:53 AM, David Gibson wrote:
> This makes a number of cleanups to handling of mapping failures during
> memory hotplug on Power:
> 
> For errors creating the linear mapping for the hot-added region:
>   * This is now reported with EFAULT which is more appropriate than the
>     previous EINVAL (the failure is unlikely to be related to the
>     function's parameters)
>   * An error in this path now prints a warning message, rather than just
>     silently failing to add the extra memory.
>   * Previously a failure here could result in the region being partially
>     mapped.  We now clean up any partial mapping before failing.
> 
> For errors creating the vmemmap for the hot-added region:
>    * This is now reported with EFAULT instead of causing a BUG() - this
>      could happen for external reason (e.g. full hash table) so it's better
>      to handle this non-fatally
>    * An error message is also printed, so the failure won't be silent
>    * As above a failure could cause a partially mapped region, we now
>      clean this up.

Yeah this greatly improves graceful fall back when when memory mapping
failure happens at the last level during memory hotplug.



More information about the Linuxppc-dev mailing list