[PATCH] powerpc/fsl-pci: Correct the comparison of the LTSSM

Zhiqiang Hou zhiqiang.hou at nxp.com
Mon Feb 1 14:57:05 AEDT 2016


Hi,

Any comments?

> -----Original Message-----
> From: Zhiqiang Hou [mailto:Zhiqiang.Hou at freescale.com]
> Sent: 2016年1月4日 15:45
> To: linuxppc-dev at lists.ozlabs.org; benh at kernel.crashing.org; paulus at samba.org;
> mpe at ellerman.id.au
> Cc: Scott Wood <scottwood at freescale.com>; akpm at linux-foundation.org;
> robh at kernel.org; Mingkai.Hu at freescale.com; Hou Zhiqiang
> <Zhiqiang.Hou at freescale.com>
> Subject: [PATCH] powerpc/fsl-pci: Correct the comparison of the LTSSM
> 
> From: Hou Zhiqiang <Zhiqiang.Hou at freescale.com>
> 
> Only the value PCIE_LTSSM_L0 stands for the link is up, instead of >=
> PCIE_LTSSM_L0.
> 
> Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou at freescale.com>
> ---
>  arch/powerpc/sysdev/fsl_pci.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/powerpc/sysdev/fsl_pci.c b/arch/powerpc/sysdev/fsl_pci.c index
> 610f472..1595f55 100644
> --- a/arch/powerpc/sysdev/fsl_pci.c
> +++ b/arch/powerpc/sysdev/fsl_pci.c
> @@ -73,7 +73,7 @@ static int fsl_pcie_check_link(struct pci_controller *hose)
>  					       PCIE_LTSSM, 4, &val);
>  		else
>  			early_read_config_dword(hose, 0, 0, PCIE_LTSSM, &val);
> -		if (val < PCIE_LTSSM_L0)
> +		if (val != PCIE_LTSSM_L0)
>  			return 1;
>  	} else {
>  		struct ccsr_pci __iomem *pci = hose->private_data;
> --
> 2.1.0.27.g96db324

Thanks,
Zhiqiang


More information about the Linuxppc-dev mailing list