powerpc: cmp -> cmpd for 64-bit

Joel Stanley joel at jms.id.au
Wed Dec 14 14:31:50 AEDT 2016


On Wed, Oct 26, 2016 at 8:51 PM, Michael Ellerman
<patch-notifications at ellerman.id.au> wrote:
> On Thu, 2016-06-10 at 13:42:19 UTC, Segher Boessenkool wrote:
>> PowerPC's "cmp" instruction has four operands.  Normally people write
>> "cmpw" or "cmpd" for the second cmp operand 0 or 1.  But, frequently
>> people forget, and write "cmp" with just three operands.
>>
>> With older binutils this is silently accepted as if this was "cmpw",
>> while often "cmpd" is wanted.  With newer binutils GAS will complain
>> about this for 64-bit code.  For 32-bit code it still silently assumes
>> "cmpw" is what is meant.
>>
>> Signed-off-by: Segher Boessenkool <segher at kernel.crashing.org>
>
> Applied to powerpc fixes, thanks.
>
> I added:
>   Fixes: 948cf67c4726 ("powerpc: Add NAP mode support on Power7 in HV mode")
>   Cc: stable at vger.kernel.org # v3.0
>
> https://git.kernel.org/powerpc/c/80f23935cadb1c654e81951f5a8b7c

This one made it into 4.9-rc3 as "powerpc: Convert cmp to cmpd in idle
enter sequence". We need it to build the 4.4 kernel with GCC 6.2, so
my OpenPower firmware builds are failing.

The patch won't backport directly as in 4.4 the macro is in
arch/powerpc/kernel/idle_power7.S.

Greg, is this one in your queue? Do we need to send a patch to stable
that backports cleanly?

Cheers,

Joel


More information about the Linuxppc-dev mailing list