[PATCH v2] powerpc: sstep.c: Add modsw, moduw instruction emulation

Naveen N. Rao naveen.n.rao at linux.vnet.ibm.com
Tue Dec 13 18:49:16 AEDT 2016


On 2016/12/13 01:06PM, PrasannaKumar Muralidharan wrote:
> Hi Naveen,
> 
> >> Add modsw and moduw instruction emulation support to analyse_instr.
> >> modsw is an x-form instruction that calculates signed modulo of values
> >> stored in registers. moduw is similar to modsw but it works with
> >> unsigned values.
> >>
> >> Changes in v2:
> >> Don't update CR register as the instruction does not touch that
> >> Arrange extended opcode in numerical order
> >
> > This changelog should come after '---' below so that it doesn't get
> > included in the commit message.
> 
> Oh, I see. Should I send the patch again with the above change? If so
> should I mark it v3 or just v2?

Easier for benh/mpe if you do ;)
Be sure to include my reviewed-by tag in your v3.

- Naveen

> 
> > Apart from that, for this patch:
> > Reviewed-by: Naveen N. Rao <naveen.n.rao at linux.vnet.ibm.com>
> 
> Thanks and regards,
> PrasannaKumar
> 



More information about the Linuxppc-dev mailing list