[PATCH] PPC: sstep.c: Add modsw, moduw instruction emulation

Naveen N. Rao naveen.n.rao at linux.vnet.ibm.com
Tue Dec 6 17:35:11 AEDT 2016


On 2016/12/06 01:21AM, PrasannaKumar Muralidharan wrote:
> >> +
> >> +             case 267:       /* moduw */
> >
> > Please move this case further up so that the extended opcodes are in
> > numerical order.
> 
> Placed it after divide instruction as it appeared logical. Also placed
> 267 below 779 as it is the order in which the instructions are
> documented in the ISA book. This may help in finding related
> instructions together. If this style is not preferred I can arrange it
> in numerical order.

I guessed as much, but if you look at the existing function, you'll see 
that things have been arranged in numerical order. As such, it's best to 
stick to that convention.

- Naveen



More information about the Linuxppc-dev mailing list