[PATCH v3] powerpc/pseries: use pci_host_bridge.release_fn() to kfree(phb)

Mauricio Faria de Oliveira mauricfo at linux.vnet.ibm.com
Fri Aug 12 03:35:09 AEST 2016

On 08/11/2016 02:01 AM, Andrew Donnellan wrote:
> In cxl, we currently call:
>     pci_remove_root_bus(phb->bus);
>     pcibios_free_controller(phb);
> which appears to break with this patch after I wire up
> pci_set_host_bridge_release() in cxl, as phb can be freed before we call
> pcibios_free_controller().

Ugh; you're right. I believe the user is expected to use either one way
or another, but now I see it's not that intuitive -- a design fault.

I'll address this w/ the other review/suggestion by Gavin; replying it.

> Missing a '---' here :)
>> Changelog:

Ok, thanks!

Mauricio Faria de Oliveira
IBM Linux Technology Center

More information about the Linuxppc-dev mailing list