[PATCH] powerpc: rebuild vdsos correctly

Michael Ellerman mpe at ellerman.id.au
Tue Aug 9 14:49:25 AEST 2016


Nicholas Piggin <npiggin at gmail.com> writes:

> diff --git a/arch/powerpc/kernel/vdso32/Makefile b/arch/powerpc/kernel/vdso32/Makefile
> index cbabd14..ae1f245 100644
> --- a/arch/powerpc/kernel/vdso32/Makefile
> +++ b/arch/powerpc/kernel/vdso32/Makefile
> @@ -39,14 +39,14 @@ $(obj)/%.so: $(obj)/%.so.dbg FORCE
>  	$(call if_changed,objcopy)
>  
>  # assembly rules for the .S files
> -$(obj-vdso32): %.o: %.S
> +$(obj-vdso32): %.o: %.S FORCE
>  	$(call if_changed_dep,vdso32as)
>  
>  # actual build commands
>  quiet_cmd_vdso32ld = VDSO32L $@
> -      cmd_vdso32ld = $(CROSS32CC) $(c_flags) -Wl,-T $^ -o $@
> +      cmd_vdso32ld = $(CROSS32CC) $(c_flags) -o $@ -Wl,-T$(filter %.lds,$^) $(filter %.o,$^)
>  quiet_cmd_vdso32as = VDSO32A $@
> -      cmd_vdso32as = $(CROSS32CC) $(a_flags) -c -o $@ $<
> +      cmd_vdso32as = $(CROSS32CC) $(a_flags) -o $@ -c $<

Are the two changes above required, they aren't obviously related.

cheers


More information about the Linuxppc-dev mailing list